Skip to content

Fix reload feed button does nothing#5430

Merged
XiangRongLin merged 2 commits intoTeamNewPipe:devfrom
Stypox:fix-feed
Jan 18, 2021
Merged

Fix reload feed button does nothing#5430
XiangRongLin merged 2 commits intoTeamNewPipe:devfrom
Stypox:fix-feed

Conversation

@Stypox
Copy link
Member

@Stypox Stypox commented Jan 16, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This was caused by view binding PR. initListeners was being called before the bindings were assigned, and therefore the click listener was never setup. @Isira-Seneviratne

Due diligence

@XiangRongLin XiangRongLin added the bug Issue is related to a bug label Jan 17, 2021
@Stypox
Copy link
Member Author

Stypox commented Jan 18, 2021

@XiangRongLin could you review this? :-)

XiangRongLin
XiangRongLin requested changes Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initListeners was being called before the bindings were assigned, and therefore the click listener was never setup

Add that reasoning to the commit message

@XiangRongLin
Copy link
Collaborator

XiangRongLin commented Jan 18, 2021 •
edited
Loading

Unrelated, but is it intended that it's possible for _feedbinding to be null while accessing it? For example here

NewPipe/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt

Line 95 in 5e544e6

listState = _feedBinding?.itemsList?.layoutManager?.onSaveInstanceState()

If not, all usages of _feedbinding should be replaced with feedbinding, to not silently break features, but breaking them visibly

Also since you are already there, to me it looks like _errorBinding does not need that weird setup. It can just be a lateinit var. Because unlike _feedbinding it's not set to null in onDestroyView

@Stypox
Copy link
Member Author

Stypox commented Jan 18, 2021 •
edited
Loading

Also since you are already there, to me it looks like _errorBinding does not need that weird setup. It can just be a lateinit var. Because unlike _feedbinding it's not set to null in onDestroyView

_errorBinding will be removed completely in #5148, so I'm not taking care of it here (though I was tempted to ;-)) I did it anyway

If not, all usages of _feedbinding should be replaced with feedbinding, to not silently break features, but breaking them visibly

I agree, I'm going to remove them

@Stypox
Copy link
Member Author

Stypox commented Jan 18, 2021

Done @XiangRongLin

Stypox added 2 commits January 18, 2021 11:42
@Stypox
Fix reload feed button does nothing
d3d05d6 
initListeners was being called before the bindings were assigned, and therefore the click listener was never setup
@Stypox
Refactor feed fragment
fa7613b
@XiangRongLin XiangRongLin merged commit 5814743 into TeamNewPipe:dev Jan 18, 2021
This was referenced Jan 18, 2021
Closed
Merged
@XiangRongLin XiangRongLin mentioned this pull request Jan 20, 2021
Merged
5 tasks
@ghost ghost mentioned this pull request Apr 11, 2021
Open
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 21, 2021
@XiangRongLin @tossj
Merge pull request TeamNewPipe/NewPipe#5430 from Stypox/fix-feed
7e9648e 
Fix reload feed button does nothing
@Stypox Stypox deleted the fix-feed branch August 4, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XiangRongLin XiangRongLin XiangRongLin approved these changes

Assignees

No one assigned

Labels

bug Issue is related to a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Stypox @XiangRongLin